Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Replaced remaining IPFS routes with pinata getData #1348

Merged
merged 2 commits into from
May 17, 2024
Merged

Fix: Replaced remaining IPFS routes with pinata getData #1348

merged 2 commits into from
May 17, 2024

Conversation

sepehr2github
Copy link
Contributor

@sepehr2github sepehr2github commented May 17, 2024 •
edited
Loading

Description

  • Replaced remaining IPFS routes with pinata getData

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I have tested my code on the test network.

@sepehr2github sepehr2github changed the title Fix: Removed remaining Fix: Replaced remaining IPFS routes with pinata getData May 17, 2024
@sepehr2github sepehr2github marked this pull request as ready for review May 17, 2024 08:07
@sepehr2github sepehr2github requested a review from a team May 17, 2024 08:07
thekidnamedkd
thekidnamedkd approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@thekidnamedkd thekidnamedkd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@sepehr2github sepehr2github merged commit 570313f into develop May 17, 2024
3 checks passed
@sepehr2github sepehr2github deleted the fix/remove-old-IPFS-resolver branch May 17, 2024 11:06
@sepehr2github sepehr2github restored the fix/remove-old-IPFS-resolver branch May 22, 2024 12:01
@cgero-eth cgero-eth deleted the fix/remove-old-IPFS-resolver branch October 1, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thekidnamedkd thekidnamedkd thekidnamedkd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sepehr2github @thekidnamedkd