fix: APP-3070 - Update WC network switch flow via dAppConnect #1330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thekidnamedkd
changed the title
cgero-eth
reviewed
Apr 19, 2024
|
@sepehr2github @cgero-eth it's kind of a long set up for this scenario, but as evidence here's the console before and after clicking 'switch network' in the network error modal: 
|
cgero-eth
reviewed
Apr 22, 2024
thekidnamedkd
changed the title
cgero-eth
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
Much cleaner now by using wagmi functionalities, thanks @thekidnamedkd! Let's only remove the console logs and we can merge the PR
Barukimang
pushed a commit
that referenced
this pull request
May 2, 2024
* wip: show possible solution for aligning WC network with app network * chore: add more detail to comments, default chain in WAGMI as mainnet * chore: remove extra console.log * chore: move global network switch to network error modal flow * chore: remove extra console.log * chore: refactor WC connector + switch to be more defensive * chore: refactor to use wagmi hook directly, remove custom switchNetwork * chore: remove console logs, unneeded connector hooks
Barukimang
added a commit
that referenced
this pull request
May 28, 2024
…s) (#1351) * fix localhost url * enable running localserver before test * fix dao creation * fix create proposal * fix: APP-3028 - Fix strings for approve and execute transaction dialog (#1332) * fix: APP-2956 - Refine session detection for terminated sessions on dAppConnect Actions flow (#1333) * fix: refine session detection for terminated sessions on dapp, connected apps key to more unique topic string, memoize session * chore: implement useRef for better lifecycle, race condition handling * chore: swap out piece of state in favor of ref * chore: remove unused import * chore: refactor if statement, clean up comments * fix: APP-3070 - Update WC network switch flow via dAppConnect (#1330) * wip: show possible solution for aligning WC network with app network * chore: add more detail to comments, default chain in WAGMI as mainnet * chore: remove extra console.log * chore: move global network switch to network error modal flow * chore: remove extra console.log * chore: refactor WC connector + switch to be more defensive * chore: refactor to use wagmi hook directly, remove custom switchNetwork * chore: remove console logs, unneeded connector hooks * fix: APP-3069 - Fix "all fields must have valid input" invalid error for all SCC proxy contracts (#1335) * fix SCC ABI validaiton * fix lint errors * resolve comments * fix: Fix gasless proposal creation and mint action for gasless DAOs (#1334) * fix vote and execute * fix create new token dao * improve existing token test * fix tests --------- Co-authored-by: cgero.eth <[email protected]> Co-authored-by: Kevin Davis <[email protected]> Co-authored-by: Sepehr Sanaei <[email protected]> Co-authored-by: selankon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
proposed solution to align the WalletConnect connector with the current app network (chainId) across the app
Task: APP-3070
Type of change
Checklist: