Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: APP-3034 - Remove support for goerli based networks #1329

Merged
merged 3 commits into from
Apr 18, 2024
Merged

chore: APP-3034 - Remove support for goerli based networks #1329

merged 3 commits into from
Apr 18, 2024

Conversation

sepehr2github
Copy link
Contributor

@sepehr2github sepehr2github commented Apr 16, 2024 •
edited by jira bot
Loading

Description

  • Removed goerli based networks

Task: APP-3034

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I have tested my code on the test network.

@sepehr2github sepehr2github changed the title chore: app-3034 - removed goerli based networks chore: app-3034 - remove goerli based networks Apr 17, 2024
@sepehr2github sepehr2github requested a review from a team April 17, 2024 06:26
@sepehr2github sepehr2github changed the title chore: app-3034 - remove goerli based networks chore: APP-3034 - remove goerli based networks Apr 17, 2024
@sepehr2github sepehr2github changed the title chore: APP-3034 - remove goerli based networks chore: APP-3034 - remove support for goerli based networks Apr 17, 2024
@sepehr2github sepehr2github changed the title chore: APP-3034 - remove support for goerli based networks chore: APP-3034 - Remove support for goerli based networks Apr 17, 2024
cgero-eth
cgero-eth reviewed Apr 17, 2024
View reviewed changes
Copy link
Member

@cgero-eth cgero-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sepehr2github, looks clean!

src/utils/constants/chains.ts Outdated Show resolved Hide resolved
src/utils/constants/chains.ts Show resolved Hide resolved
@sepehr2github sepehr2github requested a review from cgero-eth April 18, 2024 07:50
cgero-eth
cgero-eth approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@cgero-eth cgero-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @sepehr2github!

@cgero-eth cgero-eth merged commit 8752b02 into develop Apr 18, 2024
3 of 4 checks passed
@cgero-eth cgero-eth deleted the chore/app-3034 branch April 18, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgero-eth cgero-eth cgero-eth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sepehr2github @cgero-eth