Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: APP-2687 - Add e2e tests for all 4 DAO types (Wallet Based and 3 x Token Based) #1324

Merged
merged 38 commits into from
Apr 19, 2024

Conversation

Barukimang
Copy link
Collaborator

@Barukimang Barukimang commented Apr 12, 2024

Description

These are automated E2E-tests using Synpress + Playwright now covering all four DAO types.

FYI: this PR seems to have included the commits of an already merged PR into this PR: #1305

Develop has been merged with the changes of the already merged PR into this PR however: 3252943

Task: APP-2687

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the test network.

@Barukimang Barukimang requested a review from cgero-eth April 12, 2024 15:02
@cgero-eth cgero-eth changed the title chore: App2687 - Create tests for all 4 DAO types (Wallet Based and 3 x Token Based) chore: APP-2687 - Create tests for all 4 DAO types (Wallet Based and 3 x Token Based) Apr 16, 2024
Copy link
Member

@cgero-eth cgero-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new e2e tests @Barukimang!

@cgero-eth cgero-eth changed the title chore: APP-2687 - Create tests for all 4 DAO types (Wallet Based and 3 x Token Based) chore: APP-2687 - Add e2e tests for all 4 DAO types (Wallet Based and 3 x Token Based) Apr 19, 2024
@cgero-eth cgero-eth merged commit ce7c5dd into develop Apr 19, 2024
3 of 4 checks passed
@cgero-eth cgero-eth deleted the chore/app-2687-tests-four-dao-types branch April 19, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants