Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: APP-3030 - Update ExecuteProposal process to use new standard transaction flow #1322

Merged
merged 28 commits into from
Apr 19, 2024
Merged

feat: APP-3030 - Update ExecuteProposal process to use new standard transaction flow #1322

merged 28 commits into from
Apr 19, 2024

Conversation

cgero-eth
Copy link
Member

@cgero-eth cgero-eth commented Apr 11, 2024 •
edited
Loading

Description

  • Update create-proposal process to use new transaction flow

NOTE: To be merged after this PR

Task: APP-3030

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I have tested my code on the test network.

@cgero-eth cgero-eth requested a review from a team April 11, 2024 08:44
cgero-eth added 23 commits April 11, 2024 10:44
@cgero-eth
Implement ipfs-service and addData / pinData hooks
ba050ee
@cgero-eth
Implement useUploadIpfsData hook
ec3bff1
@cgero-eth
Start implementation of transaction-dialog component
9a9d251
@cgero-eth
Start implementation of create-dao-dialog component
f274192
@cgero-eth
Implement transaction-service for building transactions
f6b3712
@cgero-eth
Implement useSendTransaction hook
4c30ded
@cgero-eth
Move dao creation utilities to createDaoUtils file
45cfaf7
@cgero-eth
Continue development of transactionDialog and createDaoDialog components
c43bde0
@cgero-eth
Parse error messages, display transaction URL
ab10a1f
@cgero-eth
Remove unused import
6ff416e
@cgero-eth
Setup logging and monitoring for create-dao process
6011754
@cgero-eth
Code cleanup
6060490
@cgero-eth
Implement long-wait-timeout warning
b3724d7
@cgero-eth
Move custom transaction steps to create-dao-dialog-steps component
23ba397
@cgero-eth
Add comments to pin-metadata hook props
c5bc7c0
@cgero-eth
Hide close button when waiting for the transaction, fix loading state
48f2e71
@cgero-eth
Setup translations
89093dc
@cgero-eth
Fix rerenders and warning label, code cleanup
432b296
@cgero-eth
Add missing translations
309fce5
@cgero-eth
Prepare components for execute-transaction dialog
e1772e6
@cgero-eth
Remove query keys
8126ec0
@cgero-eth
Use new dialog
de0257b
@cgero-eth
Only build transaction when execute-proposal modal is open, handle su…
75ffe6f 
…ccess button click
@cgero-eth cgero-eth force-pushed the APP-3030-standardize-execute-proposal-flow branch from b32cf18 to 75ffe6f Compare April 11, 2024 08:45
@cgero-eth cgero-eth changed the title WIP: feat: APP-3030 - Update ExecuteProposal process to use new standard transaction flow feat: APP-3030 - Update ExecuteProposal process to use new standard transaction flow Apr 17, 2024
@cgero-eth cgero-eth marked this pull request as ready for review April 17, 2024 06:42
@github-actions GitHub Actions
Copy link

WebApp IPFS Hash: QmarknbuybjTApp4qTFn38F38nnqdAJJ184G9vJznaTUNd
WebApp deployed to https://ipfs.eth.aragon.network/ipfs/QmarknbuybjTApp4qTFn38F38nnqdAJJ184G9vJznaTUNd/

@cgero-eth cgero-eth merged commit 9dcb55f into develop Apr 19, 2024
3 checks passed
@cgero-eth cgero-eth deleted the APP-3030-standardize-execute-proposal-flow branch April 19, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cgero-eth