Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Synpress startup error and the Login test #1134

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Fix: Synpress startup error and the Login test #1134

merged 1 commit into from
Nov 16, 2023

Conversation

RakeshUP
Copy link
Contributor

Description

  • Fixes a bug that prevents Synpress from starting up
  • Fixes the metamask connect wallet test. It was broken since we moved to WalletConnect v2

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the test network.

@CLAassistant
Copy link

CLAassistant commented Nov 16, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@RakeshUP RakeshUP requested review from jamesej, Barukimang and a team and removed request for jamesej November 16, 2023 11:35
@Barukimang
Copy link
Collaborator

Great find of this 🐛 @RakeshUP !

The test login.spec.ts works super (see image below).

No other comments.

Image
image

@RakeshUP RakeshUP merged commit a4f71bc into develop Nov 16, 2023
4 of 5 checks passed
@RakeshUP RakeshUP deleted the fix-synpress branch November 16, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Barukimang Barukimang Barukimang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RakeshUP @CLAassistant @Barukimang