Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - APP-2553 Refactor to use CSS animation in mobile menu #1098

Merged
merged 3 commits into from
Oct 30, 2023

Conversation

jamesej
Copy link
Contributor

@jamesej jamesej commented Oct 27, 2023

Description

Fixing QA issue with original solution for APP-2553, this is a new PR for this ticket
Uses CSS animation and standard events to get same result as framer-motion lib and work with new modal system

Task: APP-2553

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the test network.

Copy link
Member

@cgero-eth cgero-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jamesej, tested it and it works as expected now 👌🏻

src/components/bottomSheet/index.tsx Show resolved Hide resolved
src/components/navLink/index.tsx Show resolved Hide resolved
@jamesej jamesej merged commit 7f4a39d into develop Oct 30, 2023
@jamesej jamesej deleted the fix/APP-2553-refactor branch October 30, 2023 14:47
@github-actions
Copy link

WebApp IPFS Hash: QmYSx4RzjDuQwkg8B9TPJ25RL4ENr9V86r2rfedwLvccU7
WebApp deployed to https://ipfs.eth.aragon.network/ipfs/QmYSx4RzjDuQwkg8B9TPJ25RL4ENr9V86r2rfedwLvccU7/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants