Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: APP-2563 - SDK updated & proposal approval button enabled #1096

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Fix: APP-2563 - SDK updated & proposal approval button enabled #1096

merged 2 commits into from
Oct 27, 2023

Conversation

Fabricevladimir
Copy link
Contributor

@Fabricevladimir Fabricevladimir commented Oct 27, 2023 •
edited
Loading

Description

  • updates @aragon/sdk-client to v1.17.1 in order to fix issue where member with inactive delegation is not shown.
  • fixes issue where Multisig approval button(s) are disabled when the wallet is not connected

Task: APP-2563

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the test network.

@Fabricevladimir Fabricevladimir requested a review from a team October 27, 2023 10:02
cgero-eth
cgero-eth approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@cgero-eth cgero-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Fabricevladimir

@Fabricevladimir Fabricevladimir merged commit c9d58c0 into develop Oct 27, 2023
3 of 4 checks passed
@Fabricevladimir Fabricevladimir deleted the fix/app-2563-sdk branch October 27, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgero-eth cgero-eth cgero-eth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fabricevladimir @cgero-eth