Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: APP-2564 - SDK version bump #1091

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Chore: APP-2564 - SDK version bump #1091

merged 2 commits into from
Oct 24, 2023

Conversation

Fabricevladimir
Copy link
Contributor

@Fabricevladimir Fabricevladimir commented Oct 24, 2023 •
edited by jira bot
Loading

Description

  • updates @aragon/sdk-client version
  • fixes ENS subdomain requirement when creating a DAO

Task: APP-2564

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the test network.

@Fabricevladimir Fabricevladimir requested a review from a team October 24, 2023 14:35
cgero-eth
cgero-eth approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@cgero-eth cgero-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@Fabricevladimir Fabricevladimir merged commit d532733 into develop Oct 24, 2023
4 of 5 checks passed
@Fabricevladimir Fabricevladimir deleted the chore/sdk-bump branch October 24, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgero-eth cgero-eth cgero-eth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fabricevladimir @cgero-eth