in Core.js - UNSAFE_willMount removed & put defaultSort to url #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UNSAFE_willMount() and _loadProps() are removed.
Because of defaultSort set to 'Cat', the 'City' was not appeared even the url search params are empty.
So, added putSearchParams() to componentDidMound().
It makes the url has the search params 'cat' automatically.
Then, even if you type in 'localhost:1234', the url automatically changes to 'localhost:1234/?cat'
Probably it isn't what you want.
Then you need to remove the whole defaultSort params from App.js to Core.js