Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(repo): git clone output to Stderr #7561

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dangogh
Copy link

@dangogh dangogh commented Sep 19, 2024

Description

This ensures that git clone output is directed to os.Stderr instead of os.Stdout. Test added to demonstrate that stdout is empty after clone.

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@CLAassistant
Copy link

CLAassistant commented Sep 19, 2024

CLA assistant check
All committers have signed the CLA.

@dangogh
Copy link
Author

dangogh commented Sep 19, 2024

NOTE: currently unable to run mage test:unit due to an error: ../../wasm/sdk.go:146:10: cannot use uintptr(size) (value of type uintptr) as int value in assignment. Probably something due to my macbook pro M3 installlation. I'll bring up in discussions tomorrow if unable to resolve that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(repo): git CLI output mangles stdout
2 participants