Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump go-ebs-file #7513

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

nikpivkin
Copy link
Contributor

@nikpivkin nikpivkin commented Sep 16, 2024

Description

This PR has updated the go-ebs-file to include the EBS update. Now, if the user does not specify the region in one of the possible ways, the sdk will return an error related to missing region instead of trying to access the service.

Before

2024-09-16T12:58:00+06:00	FATAL	Fatal error
  - vm scan error:
    github.com/aquasecurity/trivy/pkg/commands/artifact.Run
        /home/runner/work/trivy/trivy/pkg/commands/artifact/run.go:386
  - scan error:
    github.com/aquasecurity/trivy/pkg/commands/artifact.(*runner).scanArtifact
        /home/runner/work/trivy/trivy/pkg/commands/artifact/run.go:260
  - scan failed:
    github.com/aquasecurity/trivy/pkg/commands/artifact.(*runner).scan
        /home/runner/work/trivy/trivy/pkg/commands/artifact/run.go:615
  - failed analysis:
    github.com/aquasecurity/trivy/pkg/scanner.Scanner.ScanArtifact
        /home/runner/work/trivy/trivy/pkg/scanner/scan.go:158
  - EBS open error:
    github.com/aquasecurity/trivy/pkg/fanal/artifact/vm.(*EBS).Inspect
        /home/runner/work/trivy/trivy/pkg/fanal/artifact/vm/ebs.go:46
  - EBS error:
    github.com/aquasecurity/trivy/pkg/fanal/artifact/vm.(*EBS).openEBS
        /home/runner/work/trivy/trivy/pkg/fanal/artifact/vm/ebs.go:88
  - operation error EBS: ListSnapshotBlocks, https response error StatusCode: 0, RequestID: , request send failed, Get "https://ebs..amazonaws.com/snapshots/snap-03d27487772cf94a3/blocks": dial tcp: lookup ebs..amazonaws.com: no such host

After

2024-09-16T13:39:36+06:00       FATAL   Fatal error
  - vm scan error:
    github.com/aquasecurity/trivy/pkg/commands/artifact.Run
        /Users/nikita/projects/trivy/pkg/commands/artifact/run.go:386
  - scan error:
    github.com/aquasecurity/trivy/pkg/commands/artifact.(*runner).scanArtifact
        /Users/nikita/projects/trivy/pkg/commands/artifact/run.go:260
  - scan failed:
    github.com/aquasecurity/trivy/pkg/commands/artifact.(*runner).scan
        /Users/nikita/projects/trivy/pkg/commands/artifact/run.go:615
  - failed analysis:
    github.com/aquasecurity/trivy/pkg/scanner.Scanner.ScanArtifact
        /Users/nikita/projects/trivy/pkg/scanner/scan.go:158
  - EBS open error:
    github.com/aquasecurity/trivy/pkg/fanal/artifact/vm.(*EBS).Inspect
        /Users/nikita/projects/trivy/pkg/fanal/artifact/vm/ebs.go:46
  - EBS error:
    github.com/aquasecurity/trivy/pkg/fanal/artifact/vm.(*EBS).openEBS
        /Users/nikita/projects/trivy/pkg/fanal/artifact/vm/ebs.go:88
  - operation error EBS: ListSnapshotBlocks, failed to resolve service endpoint, endpoint rule error, Invalid Configuration: Missing Region
exit status 1

Related issues

Related PRs

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@nikpivkin nikpivkin marked this pull request as ready for review September 17, 2024 05:20
@knqyf263 knqyf263 added this pull request to the merge queue Sep 18, 2024
Merged via the queue into aquasecurity:main with commit d1d7132 Sep 18, 2024
13 checks passed
@nikpivkin nikpivkin deleted the bump-go-ebs-file-2 branch September 18, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EBS snapshot scanning error - incorrect API endpoint
2 participants