Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(misconf): Register checks only when needed #7435

Merged
merged 1 commit into from
Sep 17, 2024
Merged

feat(misconf): Register checks only when needed #7435

merged 1 commit into from
Sep 17, 2024

Conversation

simar7
Copy link
Member

@simar7 simar7 commented Sep 2, 2024 •
edited
Loading

Description

Only register checks when needed, removing the init function to do so.

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@simar7 simar7 marked this pull request as ready for review September 9, 2024 20:00
@simar7 simar7 added this pull request to the merge queue Sep 17, 2024
Merged via the queue into main with commit f768d3a Sep 17, 2024
14 checks passed
@simar7 simar7 deleted the register-misconf-checks-on-use branch September 17, 2024 04:20
@aqua-bot aqua-bot mentioned this pull request Sep 17, 2024
Merged
@shino shino mentioned this pull request Sep 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikpivkin nikpivkin nikpivkin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(misconf): Improve check registration and loading
2 participants
@simar7 @nikpivkin