feat(misconf): variable support for Terraform Plan #7228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nikpivkin <[email protected]>
simar7
reviewed
Aug 7, 2024
Comment on lines
+56
to
+58
| if len(v.Msgpack) == 0 { // len(0) because that's the default value for a "bytes" in protobuf | ||
| return nil, fmt.Errorf("dynamic value does not have msgpack serialization") | ||
| } |
There was a problem hiding this comment.
I'm not sure if I understand the comment, we check the len to be zero to ensure that what we are unpacking is msgpack right?
There was a problem hiding this comment.
Terraforom stores cty values in msgpack encoding . If the byte length is 0, it means a invalid value is represented. I looked up the implementation in Terraform.
simar7
reviewed
Aug 7, 2024
Comment on lines
+180
to
+186
|
|
||
| for _, file := range protoFiles { | ||
| if err := sh.RunV("protoc", ".", "paths=source_relative", "--go_out", ".", "--go_opt", | ||
| "paths=source_relative", file); err != nil { | ||
| return err | ||
| } | ||
| } |
There was a problem hiding this comment.
If it is run in the container, would we need to update https://github.com/aquasecurity/trivy/blob/5e20c115fee9196943a3715c4f85bb3eac9d7d66/Dockerfile.protoc as well?
There was a problem hiding this comment.
There was a problem hiding this comment.
mage:protoc command builds an image and runs it. The dockerfile does not need to be updated.
simar7
changed the title
simar7
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for input variables that are stored in Terraform Plan.
Related issues
Checklist