-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sbom): detect OS from purl
if OS component not found
#7101
base: main
Are you sure you want to change the base?
fix(sbom): detect OS from purl
if OS component not found
#7101
Conversation
} | ||
return s | ||
}) | ||
return xerrors.Errorf("multiple OSes in SBOM are not supported (%q)", oses) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought about it.
We can leave this error.
But if we get problems about this - we will update the logic to get the OS (from purl
) with the maximum number of packages.
@DmitriyLewen thank you for creating this PR, I too am seeing a lot of warnings when scanning wolfi images. Question unrelated to PR: For these warning you mention in discussions/7073, is Trivy unable to scan the packages in the image therefore being unable to report accurate vulnerability info for Wolfi images? |
Hello @eshafaq1
Trivy detects the following packages from
IIUC packages from p1 and p2 is same (duplicates). |
Hopefully @knqyf263 can get some time to review :) |
This PR is stale because it has been labeled with inactivity. |
Description
There are cases when SBOM file doesn't contain
OS component
.To avoid missing OS packages -we can try to get OS from
purl
.More details - #7073 (reply in thread)
Related issues
purl
if OS component not found #7100Checklist