Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nodejs): merge Indirect, Dev, ExternalReferences fields for same deps from package-lock.json files v2 or later #6356

Merged

Conversation

DmitriyLewen
Copy link
Contributor

Description

There are times when package-lock.json contains 2 (or more) identical dependencies, but

  • only one of these dependencies is Dev.
  • only one of these dependencies is Indirect.

We need to combine these dependencies correctly.
Also we need to merge ExternalReferences rather than overwrite them.

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@knqyf263 knqyf263 enabled auto-merge March 27, 2024 05:46
@knqyf263 knqyf263 added this pull request to the merge queue Mar 27, 2024
Merged via the queue into aquasecurity:main with commit 258d153 Mar 27, 2024
12 checks passed
@DmitriyLewen DmitriyLewen deleted the fix-npm-v2/check-dev-for-same-pkgs branch March 28, 2024 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npm: inconsistent results when dependency has both a dev and non-dev entry in lockfile
2 participants