feat(rust): Support workspace.members parsing for Cargo.toml analysis #5285
Conversation
|
|
There was a problem hiding this comment.
Hello @anfedotoff
Thanks for your work!
I left some comments. Take a look, when you have time, please.
Regards, Dmitriy
|
@DmitriyLewen, sorry for too long, but I'm done with fixes. Please, have a look, if you have time:). |
|
Good! |
There was a problem hiding this comment.
@anfedotoff I left a few small comments.
I also forgot to ask you to add a test for members.
and one more thing - can you show how Cargo builds a dependency tree for participants.
I'm worried about direct/indirect dependencies.
|
@anfedotoff Can you take a look on test errors (windows tests are broken)? |
Hmm, honestly, I don't understand why this is happened. Maybe that test is flaky? Could you restart it, please? |
I don't think it's flaky. It shows a file open error. |
|
This PR is stale because it has been labeled with inactivity. |
github-actions
bot
added
the
lifecycle/stale
DmitriyLewen
removed
the
lifecycle/stale
|
@knqyf263 I fixed Windows tests and did some small refactoring for this PR. |
| ID: "[email protected]", | ||
| Name: "regex", | ||
| Version: "1.10.2", | ||
| Indirect: true, |
There was a problem hiding this comment.
Shouldn't it be false (meaning a direct dependency)? It is defined in Cargo.toml.
| log.Logger.Warnf("Unable to parse %q: %s", memberPath, err) | ||
| continue | ||
| } | ||
| maps.Copy(dependencies, memberDeps) |
There was a problem hiding this comment.
IIUC, workspace.dependencies is overridden by mistake here and then loses the version constraint.
There was a problem hiding this comment.
You are right.
Thanks!
Fixed in 7b31975
Signed-off-by: knqyf263 <[email protected]>
Description
Related issues
Checklist