Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add line numbers for lint output #5247

Merged
merged 3 commits into from
Sep 28, 2023
Merged

chore: Add line numbers for lint output #5247

merged 3 commits into from
Sep 28, 2023

Conversation

simar7
Copy link
Member

@simar7 simar7 commented Sep 26, 2023

Description

This adds the ability to see line numbers when linter has problems to report.

image image

Related PRs

@simar7 simar7 self-assigned this Sep 26, 2023
@simar7 simar7 marked this pull request as ready for review September 26, 2023 07:36
@knqyf263
Copy link
Collaborator

knqyf263 commented Sep 26, 2023

Nice! BTW, when the linter fails, can we show a message like "Try mage lint:fix"?

@simar7
Copy link
Member Author

simar7 commented Sep 26, 2023

Nice! BTW, when the linter fails, can we show a message like "Try mage lint:fix"?

Added ab4a095

Copy link
Collaborator

@knqyf263 knqyf263 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left small comments, but it is up to you. You can merge the PR as is if you want.

.github/workflows/test.yaml Outdated Show resolved Hide resolved
@knqyf263 knqyf263 added this pull request to the merge queue Sep 28, 2023
Merged via the queue into main with commit 0c08dde Sep 28, 2023
21 checks passed
@knqyf263 knqyf263 deleted the linter-line-numbers branch September 28, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants