Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(db): allow passing registry options #5226

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

mymichu
Copy link
Contributor

@mymichu mymichu commented Sep 21, 2023

Description

It is currently not possible to download the java-vulnerability-db from a private registry. This changes allows developers using the Golang package to download the java-vulnerability-db from a private container registry and pass oci-registry options. Nothing changes for a CLI user, only for developers utilising the pkg/javadb directly. I changed the Init interface of the javadb which is a breaking change, another possibility would be to add a new Initi function. Let me know what you think.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@CLAassistant
Copy link

CLAassistant commented Sep 21, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@mymichu mymichu changed the title feat(javadb): allow passing registry options feat(db): allow passing registry options Sep 21, 2023
Copy link
Contributor

@DmitriyLewen DmitriyLewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @mymichu
Thanks for your work!

I left comment. Take a look, please.

Regards, Dmitriy

pkg/commands/artifact/run.go Outdated Show resolved Hide resolved
Copy link
Contributor

@DmitriyLewen DmitriyLewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work!
LGTM.

@knqyf263 can you look and merge if everything is ok?

@knqyf263 knqyf263 added this pull request to the merge queue Sep 27, 2023
Merged via the queue into aquasecurity:main with commit 908a491 Sep 27, 2023
11 checks passed
@mymichu mymichu deleted the feature/java-db-credentials branch September 27, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants