-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(db): allow passing registry options #5226
feat(db): allow passing registry options #5226
Conversation
|
Signed-off-by: Michel Meyer <[email protected]>
e3749bd
to
5ed408d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work!
LGTM.
@knqyf263 can you look and merge if everything is ok?
Description
It is currently not possible to download the java-vulnerability-db from a private registry. This changes allows developers using the Golang package to download the java-vulnerability-db from a private container registry and pass oci-registry options. Nothing changes for a CLI user, only for developers utilising the pkg/javadb directly. I changed the Init interface of the javadb which is a breaking change, another possibility would be to add a new Initi function. Let me know what you think.
Checklist