feat(dotnet): add license support for NuGet #5217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DmitriyLewen
commented
Sep 21, 2023
knqyf263
reviewed
Sep 27, 2023
Comment on lines
78
to
82
| if license := pkg.Metadata.License; license.Type == "expression" && license.Text != "" { | ||
| return []string{license.Text}, nil | ||
| } | ||
|
|
||
| return nil, nil |
There was a problem hiding this comment.
nit: I prefer the happy path getting aligned to the left edge.
https://medium.com/@matryer/line-of-sight-in-code-186dd7cdea88
Suggested change
| if license := pkg.Metadata.License; license.Type == "expression" && license.Text != "" { | |
| return []string{license.Text}, nil | |
| } | |
| return nil, nil | |
| if license := pkg.Metadata.License; license.Type != "expression" || license.Text == "" { | |
| return nil, nil | |
| } | |
| return []string{pkg.Metadata.License}, nil |
There was a problem hiding this comment.
Changed in 1d0fed1
Comment on lines
78
to
82
| if err != nil { | ||
| if !errors.Is(err, fs.ErrNotExist) { | ||
| return xerrors.Errorf("license find error: %w", err) | ||
| } | ||
| } |
There was a problem hiding this comment.
nit: We might want to aggregate the statements.
Suggested change
| if err != nil { | |
| if !errors.Is(err, fs.ErrNotExist) { | |
| return xerrors.Errorf("license find error: %w", err) | |
| } | |
| } | |
| if err != nil && !errors.Is(err, fs.ErrNotExist) { | |
| return xerrors.Errorf("license find error: %w", err) | |
| } |
There was a problem hiding this comment.
Right! Thanks! Updated in 1d0fed1.
knqyf263
approved these changes
Sep 27, 2023
|
@knqyf263 looks like this PR has not been added to merge queue. |
|
CLA assistant didn't work. I opened the following link to trigger it. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
packages.configandpackages.lock.jsonfiles don't have information about the licenses used.Add support of *.nuspec files from global packages folder.
notes:
NUGET_PACKAGESenvironment variable are supported.licenseUrlis not supported, because this field has been deprecated.expressiononly supportsExample:
Related issues
Checklist