-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Package.resolved swift files support #4932
feat: add Package.resolved swift files support #4932
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We didn't add ID
in Package
. Didn't you see any implications?
https://github.com/aquasecurity/go-dep-parser/blob/e39b9645d9b842013a443b800af87608f010a532/pkg/swift/swift/parse.go#L37-L44
func (a swiftLockAnalyzer) Required(_ string, fileInfo os.FileInfo) bool { | ||
return fileInfo.Name() == types.SwiftResolved | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think other analyzers use filePath
.
func (a swiftLockAnalyzer) Required(_ string, fileInfo os.FileInfo) bool { | |
return fileInfo.Name() == types.SwiftResolved | |
} | |
func (a swiftLockAnalyzer) Required(filePath string, _ os.FileInfo) bool { | |
return path.Base(filePath) == types.SwiftResolved | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm.. i don't know why i used FileInfo...
Thanks! Changed in 9d1e8b6
We usually use Peghaps we can use |
We already use |
You are right. I will add this. UPD: added changes in 3479840 |
Description
Add Package.resolved files support.
Example of work:
Related issues
Related PRs
Checklist