Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(misconf): Improve check registration and loading #7434

Closed
simar7 opened this issue Sep 2, 2024 · 0 comments · Fixed by #7435
Closed

feat(misconf): Improve check registration and loading #7434

simar7 opened this issue Sep 2, 2024 · 0 comments · Fixed by #7435
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. scan/misconfiguration Issues relating to misconfiguration scanning
Milestone

Comments

@simar7
Copy link
Member

simar7 commented Sep 2, 2024

Today checks are registered at startup of Trivy as done here. This has a few issues:

This has the overhead of adding unnecessary loading of checks into memory (and compute time) even if there is not misconfiguration scanning at play. This also can cause slowdowns as such: #7426
and #7431

We should register the checks explicitly when misconfiguration scanner is enabled rather than doing an init func to do so.

@simar7 simar7 added kind/feature Categorizes issue or PR as related to a new feature. scan/misconfiguration Issues relating to misconfiguration scanning labels Sep 2, 2024
simar7 added a commit that referenced this issue Sep 2, 2024
@simar7 simar7 added this to the v0.56.0 milestone Sep 5, 2024
@simar7 simar7 self-assigned this Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. scan/misconfiguration Issues relating to misconfiguration scanning
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

1 participant