fix: return proper image digest #2310
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trivy Operator incorrectly reported imageID as image digest. Fixes aquasecurity#2259
dkulchinsky
reviewed
Nov 12, 2024
| // - image ID (this is what is visible in 'docker image ls command') | ||
| // Execute docker image ls --digests --no-trunc <image> to see both digest and ID. | ||
| // See https://stackoverflow.com/questions/56364643/whats-the-difference-between-a-docker-images-image-id-and-its-digest | ||
| var imageDigest = strings.Split(reports.Metadata.RepoDigests[0], "@")[1] |
There was a problem hiding this comment.
@d-mankowski-synerise any reason to strip the sha256@ prefix?
There was a problem hiding this comment.
copying from the issue you raised:
"RepoDigests": [
"<registry>/<image repo>@sha256:cf3e3b3a98edde46eac58d4745a2467b9da2bc49a11191565a893ffac38034a3"
],
so it is not stripping sha256 prefix, but <registry>/<repo>@ part
There was a problem hiding this comment.
ohh, right! mixed up the delimiters 👍🏼
| @@ -5,7 +5,10 @@ | |||
| "Family": "alpine", | |||
| "Name": "3.10.2", | |||
| "EOSL": true | |||
| } | |||
| }, | |||
| "RepoDigests": [ | |||
There was a problem hiding this comment.
not really sure why RepoDigests and other parameters are not included in this report (which, I assume, is the output of trivy i --format json alpine:3.10.2)
There was a problem hiding this comment.
yeah, looks like the fixture is incomplete, might have been generated with an older version of Trivy?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trivy Operator incorrectly reported imageID as image digest.
Fixes #2259
Description
Related issues
Remove this section if you don't have related PRs.
Checklist