refactor: Rename scanJobsRetryDelay param to avoid confusion #2260
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recently I've worked with trivy-operator and was confused because of the difference in naming the same value. In documentation it's called
OPERATOR_SCAN_JOB_RETRY_AFTER
or similarly, the same is for deploy/helm/templates/configmaps/trivy-operator-config.yaml and deploy/static/trivy-operator.yaml.Howhever, in deploy/helm/values.yaml the name of the value is
scanJobsRetryDelay
.It took some time for me to understand. That's why I suggest using the same value name -
scanJobsRetryAfter
. What do you think, @chen-keinan ?