Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Rename scanJobsRetryDelay param to avoid confusion #2260

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Elshirak
Copy link

@Elshirak Elshirak commented Sep 15, 2024

Description

Recently I've worked with trivy-operator and was confused because of the difference in naming the same value. In documentation it's called OPERATOR_SCAN_JOB_RETRY_AFTER or similarly, the same is for deploy/helm/templates/configmaps/trivy-operator-config.yaml and deploy/static/trivy-operator.yaml.

Howhever, in deploy/helm/values.yaml the name of the value is scanJobsRetryDelay.

It took some time for me to understand. That's why I suggest using the same value name - scanJobsRetryAfter. What do you think, @chen-keinan ?

  • I've read the guidelines for contributing to this repository.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant iblob/main/CONTRIBUTING.md) to this repository.

@CLAassistant
Copy link

CLAassistant commented Sep 15, 2024

CLA assistant check
All committers have signed the CLA.

@Elshirak Elshirak changed the title Rename scanJobsRetryDelay param to avoid confusion Refactor: Rename scanJobsRetryDelay param to avoid confusion Sep 15, 2024
@Elshirak Elshirak changed the title Refactor: Rename scanJobsRetryDelay param to avoid confusion refactor: Rename scanJobsRetryDelay param to avoid confusion Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants