Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Automatically build helm chart on PR merge #1460

Merged
merged 2 commits into from
Aug 31, 2023
Merged

feat: Automatically build helm chart on PR merge #1460

merged 2 commits into from
Aug 31, 2023

Conversation

adberger
Copy link
Contributor

Description

Currently the helm chart version is tied to the application version and thus tied to the application release cycle.
With this PR, a new helm chart gets automatically published if the file Chart.yaml has changed on a PR merge.

Can't be tested in a feature branch, for this reason I can't ensure this works as intended.

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@chen-keinan
Copy link
Contributor

chen-keinan commented Aug 30, 2023

@adberger just want to make sure that if appVersion will be updated as well so helm will not be published before new app release and been published , in this case helm install... will fail

@chen-keinan
Copy link
Contributor

chen-keinan commented Aug 31, 2023

@adberger thank you for this contribution.

I have added appVersion change validation.

In case appVersion has been changed the helm release will be triggered manually as before. upon official release cycle

@chen-keinan chen-keinan merged commit acdcbb2 into aquasecurity:main Aug 31, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split helm chart and application releases
2 participants