Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: declare missing properties in values.yaml #1427

Merged
merged 1 commit into from
Aug 13, 2023

Conversation

dnskr
Copy link
Contributor

@dnskr dnskr commented Aug 9, 2023

Description

The PR explicitly declares missing and commented properties used by the chart with empty or default values.
The PR includes minor README changes rendered by helm-docs run.
The PR does not change any functionality of the chart.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@dnskr dnskr requested a review from chen-keinan as a code owner August 9, 2023 22:46
@CLAassistant
Copy link

CLAassistant commented Aug 9, 2023

CLA assistant check
All committers have signed the CLA.

@chen-keinan
Copy link
Contributor

@dnskr thank you for the contribution , you'll need to run make generate-helm-docs to fix helm doc lint issue

@dnskr
Copy link
Contributor Author

dnskr commented Aug 13, 2023

@dnskr thank you for the contribution , you'll need to run make generate-helm-docs to fix helm doc lint issue

I used helm-docs command directly, but it adds the following footer:

----------------------------------------------
Autogenerated from chart metadata using [helm-docs v1.11.0](https://github.com/norwoodj/helm-docs/releases/v1.11.0)

The command make generate-helm-docs generates expected output.

@chen-keinan
Copy link
Contributor

lgtm , thank you for the contribution 🚀

@chen-keinan chen-keinan merged commit a45e359 into aquasecurity:main Aug 13, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants