Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the ADD instruction with HTTP, HTTPS and Git URLs #281

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

nicwortel
Copy link
Contributor

COPY should be preferred over ADD when simply copying a file from the build context to the container. However, ADD supports additional features such as fetching files from remote HTTP(S) and Git URLS and extracting tar files.

See https://docs.docker.com/build/building/best-practices/#add-or-copy, aquasecurity/trivy#7806 and aquasecurity/trivy#7791.

COPY should be preferred over ADD when simply copying a file from the
build context to the container. However, ADD supports additional
features such as fetching files from remote HTTP(S) and Git URLS and
extracting tar files.

See https://docs.docker.com/build/building/best-practices/#add-or-copy,
aquasecurity/trivy#7806 and
aquasecurity/trivy#7791.
@CLAassistant
Copy link

CLAassistant commented Oct 29, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@simar7 simar7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR!

@simar7 simar7 added this pull request to the merge queue Oct 29, 2024
Merged via the queue into aquasecurity:main with commit 89d7c53 Oct 29, 2024
5 checks passed
@nicwortel nicwortel deleted the allow-add-url branch October 30, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants