Fix ProcessTree rogue entries #4582
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProcessTree was populated with rogue entries because time normalization was not performed at the correct moment, leading to a mismatch between hashes from signals and those from events.
kthread was being added only as parent, so its taskinfo was not being updated.
Populate Process TaskInfo with data from sched_process_exec event. Without it, the ProcessTree when set as source=events will contain entries with no relevant data.
geyslan
force-pushed
the
proctree-the-fourth
branch
from
46d1d44 to
3365234
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close: #4580
Close: #3878
1. Explain what the PR does
3365234 chore(proctree): add debug comment
f400d59 fix(proctree): exec event already brings data
1c03c99 fix(proctree): treat kthread as special case
6132821 fix(proctree): time normalization momentum
dc544ec fix(tests): kill only tracee (-x exact match)
2b24584 chore(proctree): add exittime to debug
f400d59 fix(proctree): exec event already brings data
1c03c99 fix(proctree): treat kthread as special case
6132821 fix(proctree): time normalization momentum
2. Explain how to test it
Uncomment https://github.com/aquasecurity/tracee/pull/4582/files#diff-72195925b110a2e9579f4bd9491d18052a9fb1875d2b3757987cfdfc288a1cffR183 and run tracee with
--proctree source=both,--proctree source=events,--proctree source=signalsfor checking the current state of the ProcessTree. One might also wanna runINSTTESTS="PROCTREE_DATA_SOURCE" ./tests/e2e-inst-test.shchanging the source type inside that script before.One won't see anymore:
3. Other comments