feat(java): capture licenses from pom.xml #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knqyf263
reviewed
Jun 11, 2023
pkg/java/pom/parse_test.go
Outdated
| @@ -32,6 +32,7 @@ func TestPom_Parse(t *testing.T) { | |||
| { | |||
| Name: "com.example:happy", | |||
| Version: "1.0.0", | |||
| License: "Apache 2.0", | |||
There was a problem hiding this comment.
Looks like all licenses are Apache 2.0 other than multiply licenses. Can we change one of them to another license so that we can make sure the test identifies licenses correctly? This prevents bugs where values are not updated properly, and all values are the same by mistake.
knqyf263
approved these changes
Jun 14, 2023
7 tasks
Sq34sy
pushed a commit
to Sq34sy/go-dep-parser
that referenced
this pull request
Jul 28, 2023
Sq34sy
pushed a commit
to Sq34sy/go-dep-parser
that referenced
this pull request
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At the moment, the licenses specified in pom.xml , do not parse
Related Issues