Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new branch route53 bugfix #2084

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

new branch route53 bugfix #2084

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
686431d
new branch route53 bugfix
Sep 2, 2024
75531bf
redoing route53 dtl changes for bug fix
Sep 4, 2024
cf8a051
r53 dtl fix
Sep 4, 2024
cb3b0ae
Update plugins/aws/route53/domainTransferLock.js
alphadev4 Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/aws/eks/eksKubernetesVersion.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ describe('eksKubernetesVersion', function () {
"cluster": {
"name": "mycluster",
"arn": "arn:aws:eks:us-east-1:012345678911:cluster/mycluster",
"version": "1.27",
"version": "1.29",
}
}
);
Expand Down
32 changes: 30 additions & 2 deletions plugins/aws/route53/domainTransferLock.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,40 @@
return callback(null, results, source);
}


var dtlUnsupportedDomains= [
'.za',
'.cl',
'.ar',
'.au',
'.nz',
'.au',
'.jp',
'.qa',
'.ru',
'.ch',
'.de',
'.es',
'.eu',
'fi',
'.it',
'.nl',
'.se',
];
var unsupported = false;

for (var i in listDomains.data) {
var domain = listDomains.data[i];

if (!domain.DomainName) continue;

// Skip .uk and .co.uk domains
if (domain.DomainName.indexOf('.uk') > -1) {
dtlUnsupportedDomains.forEach((region) => {
if (domain.DomainName.includes(region)) {
unsupported = true;
}
})

Check failure on line 68 in plugins/aws/route53/domainTransferLock.js

View workflow job for this annotation

GitHub Actions / build 

Missing semicolon
alphadev4 marked this conversation as resolved.
Show resolved Hide resolved
// Skip the unsupported domains
if (unsupported) {
helpers.addResult(results, 0,
'Domain: ' + domain.DomainName + ' does not support transfer locks',
'global', domain.DomainName);
Expand Down
2 changes: 1 addition & 1 deletion plugins/aws/route53/domainTransferLock.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ const domains = [
"Expiry": 1602712345.0
},
{
"DomainName": "example.com.uk",
"DomainName": "example.com.jp",
"AutoRenew": true,
"TransferLock": true,
"Expiry": 1602712345.0
Expand Down
Loading