Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure/front door secure origin #1687

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Azure/front door secure origin #1687

wants to merge 10 commits into from

Conversation

alphadev4
Copy link
Collaborator

No description provided.

AkhtarAmir
AkhtarAmir suggested changes Aug 10, 2023
View reviewed changes
plugins/azure/frontdoor/frontDoorSecureOrigins.js Show resolved Hide resolved
plugins/azure/frontdoor/frontDoorSecureOrigins.js

if (!afdOrigin || afdOrigin.err || !afdOrigin.data) {
helpers.addResult(results, 3,
'Unable to query Azure Front Door origins: ' + helpers.addError(afdOrigin), location, profile.id);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'Unable to query Azure Front Door origins: ' + helpers.addError(afdOrigin), location, profile.id);
'Unable to query Azure Front Door origin: ' + helpers.addError(afdOrigin), location, profile.id);

@AkhtarAmir AkhtarAmir added readytogo PRs ready to merge reviewed labels Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkhtarAmir AkhtarAmir AkhtarAmir requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
readytogo PRs ready to merge reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alphadev4 @AkhtarAmir