This repository has been archived by the owner on Jan 3, 2024. It is now read-only.
Fix default retention mode with multipart uploaded objects #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irq0
reviewed
Nov 23, 2023
irq0
reviewed
Nov 23, 2023
irq0
previously requested changes
Nov 23, 2023
added 2 commits
November 23, 2023 15:45
In SFSAtomicWriter::complete(), when put RGW_ATTR_OBJECT_RETENTION attribute in attrs, directly encode RGWObjectRetention object in the map. Signed-off-by: Giuseppe Baccini <[email protected]>
When an object is uploaded with multipart, for object-lock enabled buckets, the default rentention mode must be set in the object's attributes (when a retention mode is not explicitely set by the user for the object). Therefore, RGW_ATTR_OBJECT_RETENTION must be set in the attrs of each part being uploaded in the SFSMultipartUploadV2::complete() function. Fixes: https://github.com/aquarist-labs/s3gw/issues/761 Signed-off-by: Giuseppe Baccini <[email protected]>
giubacc
force-pushed
the
fix-default-retention-mode-multipart-upload-v2
branch
from
10f1362 to
6bc54b5
Compare
jecluis
approved these changes
Dec 4, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an object is uploaded with multipart, for object-lock enabled buckets,
the default rentention mode must be set in the object's attributes
(when a retention mode is not explicitely set by the user for the object).
Therefore,
RGW_ATTR_OBJECT_RETENTIONmust be set in the attrs of each partbeing uploaded in the
SFSMultipartUploadV2::complete()function.Fixes: https://github.com/aquarist-labs/s3gw/issues/761
Contribution Guidelines
Checklist