rgw/sfs: fail gracefully if objref not created

It may happen if we conflict in-flight with another thread. Ensure we just fail gracefully to the client. Fixes: aquarist-labs/ceph#820 Signed-off-by: Joao Eduardo Luis <[email protected]>
aquarist-labs · Nov 23, 2023 · e7571be · e7571be
1 parent 1d2c6cf
commit e7571be
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/src/rgw/driver/sfs/multipart.cc b/src/rgw/driver/sfs/multipart.cc
@@ -443,6 +443,12 @@ int SFSMultipartUploadV2::complete(
         << dendl;
     return -ERR_INTERNAL_ERROR;
   }
+  if (!objref) {
+    // We were unable to create a version, but this might very well have been
+    // because we conflicted with another in-flight transaction. Lets return
+    // back to the user, and they can complete it again if they so desire.
+    return -ERR_INTERNAL_ERROR;
+  }
   auto destpath = store->get_data_path() / objref->get_storage_path();
   lsfs_debug(dpp
   ) << fmt::format("moving final object from {} to {}", objpath, destpath)