Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve comments #328

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Improve comments #328

wants to merge 1 commit into from

Conversation

kfeng123
Copy link

Improve comments, especially for TriangleAttention: c_hidden is the per-head hidden dimension, not overall hidden dimension.

…er-head hidden dimension, not overall hidden dimension.
@kfeng123 kfeng123 marked this pull request as draft June 16, 2023 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant