Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update user-controller.js #1574

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

devank21
Copy link

hactoberfest2024

Title and Issue number

Title :improved redundancy and efficiency

Issue No. : 1 (whith apu52) i am not very sure from to get the issue number so i assumed it to bee the number of times i have issued in this repo

Code Stack : node.js

Close #<issue_no>

Description

->Improved handling for missing fields (name, email, password) in signup and login.
->In login, set the JWT token in a cookie with security flags (httpOnly, secure, sameSite) for added protection against CSRF and XSS attacks.

Video/Screenshots (mandatory)

for some reason i am not able to attach the video extremely sorrry for that

Type of PR

  • Bug fix
  • Feature enhancement :
  • Documentation update
  • Other (specify): _______________

Checklist:

  • [x ] I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • [ X] I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have gone through the contributing.md file before contributing
  • [X ] I have Starred the Repository.

Additional context:

##Are you contributing under any Open-source programme?

  • I am contributing under GSSOC'24 Extended
  • [ X] I am contributing under Hacktoberfest'24

hactoberfest2024
Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Oct 26, 2024

Deploy Preview for taupe-cendol-f7e2bb ready!

Name Link
🔨 Latest commit 01d5075
🔍 Latest deploy log https://app.netlify.com/sites/taupe-cendol-f7e2bb/deploys/671d41c1b02ccb000867c3a5
😎 Deploy Preview https://deploy-preview-1574--taupe-cendol-f7e2bb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@devank21 what is your assigned issue no.??

@apu52 apu52 added question Further information is requested and removed title needs formatting labels Oct 26, 2024
@apu52 apu52 changed the title Update user-controller.js feat: Update user-controller.js Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants