Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Made navbar Uniform accross all pages #1565

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Conversation

shivam8112005
Copy link
Contributor

Title and Issue number

Title :Consistent Navbar Styling across all pages

Issue No. : #1422

Code Stack : html, CSS

Close #1422

Description

The navbar on the homepage and the dedicated-destinations pages shows inconsistencies in:

Font Style: Navbar link fonts differ.
Background Color: Navbar background colors are not uniform.
Logo Font: The logo is not present in dedicate-destinations pages.
Button Alignment: Buttons are misaligned across the dedicate-destinations pages..

Video/Screenshots (mandatory)

Screenshot 2024-10-23 162110

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Checklist:

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have gone through the contributing.md file before contributing
  • I have Starred the Repository.

Additional context:

##Are you contributing under any Open-source programme?

  • I am contributing under GSSOC'24 Extended
  • I am contributing under Hacktoberfest'24

Copy link

netlify bot commented Oct 23, 2024

Deploy Preview for taupe-cendol-f7e2bb ready!

Name Link
🔨 Latest commit b851034
🔍 Latest deploy log https://app.netlify.com/sites/taupe-cendol-f7e2bb/deploys/671e9fc052fcc700087942a8
😎 Deploy Preview https://deploy-preview-1565--taupe-cendol-f7e2bb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @shivam8112005! Thank you for your valuable contribution! Our team will review it and get back to you soon.

Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shivam8112005 this pr is facing some merge conflicts please try to resolve this so that I can review & merge this pr

@apu52 apu52 changed the title Made navbar Uniform accross all pages feat: Made navbar Uniform accross all pages Oct 26, 2024
@apu52 apu52 added help wanted Extra attention is needed and removed title needs formatting labels Oct 26, 2024
@shivam8112005
Copy link
Contributor Author

shivam8112005 commented Oct 26, 2024

@apu52 ohk i will do it by tomorrow

@shivam8112005
Copy link
Contributor Author

shivam8112005 commented Oct 27, 2024

hey @apu52 now can you merge it?

Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shivam8112005 okkk great

@apu52 apu52 merged commit eb37a74 into apu52:main Oct 28, 2024
5 checks passed
Copy link

🎉🎉 Thank you for your contribution! Your PR #1565 has been merged! 🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Inconsistent Navbar Styling Between Homepage and Dedicated Destination Pages
2 participants