Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rating can be given only after login #1348

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cecily-mee
Copy link

@cecily-mee cecily-mee commented Aug 8, 2024

Title and Issue number

Title :Unlimted rating and feedback can be given by one person

Issue No. : #684

Code Stack :

Close #684

Description

A person can give feedback only after login .

Video/Screenshots (mandatory)

image

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Checklist:

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have gone through the contributing.md file before contributing

Additional context:

##Are you contributing under any Open-source programme?

  • I am contributing under GSSOC'24
  • I am contributing under VSOC'24

Copy link

netlify bot commented Aug 8, 2024

Deploy Preview for taupe-cendol-f7e2bb ready!

Name Link
🔨 Latest commit f87087a
🔍 Latest deploy log https://app.netlify.com/sites/taupe-cendol-f7e2bb/deploys/66b4cfa69d814a00082ff36f
😎 Deploy Preview https://deploy-preview-1348--taupe-cendol-f7e2bb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cecily-mee! Thank you for your valuable contribution! Our team will review it and get back to you soon.

@cecily-mee cecily-mee changed the title Issue:684 (Rating can be given only after login) feat: rating can be given only after login Aug 8, 2024
@apu52
Copy link
Owner

apu52 commented Aug 9, 2024

@cecily-mee I have checked the code, but can u provide a video of the updation u have made?? like the user only will be able to give rating after she/he successfully logged in

@apu52 apu52 added the question Further information is requested label Aug 9, 2024
@apu52
Copy link
Owner

apu52 commented Aug 9, 2024

@cecily-mee please make all of your changes in one single PR.

@cecily-mee
Copy link
Author

i had forked the old version and hence pushing in all the changes together is not working since i recently cloned new version . so i made changes and made seperate prs

@apu52
Copy link
Owner

apu52 commented Aug 10, 2024

@cecily-mee make all the changes in one single PR ASAP maybe right now & submit it as a pr before 7 pm ....So that I can review the code & be able to merge the changes & also please try to add a video of your improvements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unlimited rating and feedback can be given by one person
2 participants