-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document well defined eval order starting from Move 2 #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
vineethk
force-pushed
the
vk/specify-eval-order
branch
from
November 12, 2024 22:03
4c8c4c4
to
91a6f7e
Compare
vineethk
force-pushed
the
vk/specify-eval-order
branch
from
November 12, 2024 22:27
91a6f7e
to
5040513
Compare
vineethk
force-pushed
the
vk/specify-eval-order
branch
from
November 12, 2024 22:37
5040513
to
5cefff4
Compare
vineethk
requested review from
a team,
gregnazario,
hariria and
igor-p
as code owners
November 12, 2024 22:43
vineethk
requested review from
rahxephon89,
wrwg,
brmataptos,
fEst1ck and
hariria
and removed request for
a team,
igor-p,
gregnazario and
hariria
November 12, 2024 22:43
vineethk
force-pushed
the
vk/specify-eval-order
branch
from
November 13, 2024 13:57
5cefff4
to
1f582c2
Compare
rahxephon89
approved these changes
Nov 13, 2024
brmataptos
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest a change in some existing line, other than that is fine.
vineethk
force-pushed
the
vk/specify-eval-order
branch
from
November 13, 2024 18:55
1f582c2
to
c7c85c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Document the well specified evaluation order starting from Move 2.
Checklist
pnpm spellcheck
?pnpm fmt
?pnpm lint
?