Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Pyth to Aptos #682

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

mariobern
Copy link

@mariobern mariobern commented Oct 26, 2024

Description

Hi all, Mario from Pyth here. Would like to add Pyth oracle and how to use Pyth on Aptos for developers

Checklist

  • Do all Lints pass?
    • Have you ran pnpm spellcheck?
    • Have you ran pnpm fmt?
    • Have you ran pnpm lint?

Copy link

vercel bot commented Oct 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
developer-docs-nextra ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 26, 2024 10:56pm

Copy link
Collaborator

@gregnazario gregnazario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@igor-p what you think about adding oracles here?

Comment on lines +10 to +15
## Pyth Network

The [Pyth Network](https://pyth.network/) is one of the largest first-party Oracle network, delivering real-time data across [a vast number of chains](https://docs.pyth.network/price-feeds/contract-addresses).

The network comprises some of the world’s [largest exchanges, market makers, and financial services providers](https://pyth.network/publishers). These publish proprietary data on-chain for aggregation and distribution to smart contract applications.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be fair to all oracles, I may have a landing page for Oracles, and allow the other oracles to additionally add theirs as subpages.

Copy link
Collaborator

@hariria hariria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might be good to have Oracles be its own directory, and have pyth as a subfile inside that

@igor-p
Copy link
Collaborator

igor-p commented Nov 6, 2024

I think it might be good to have Oracles be its own directory, and have pyth as a subfile inside that

I agree. Adding another oracle in this single page layout would make it unwieldy. The main Oracles page could have the blurb about what oracles are, then maybe link to the sub-page on the page itself (in addition to the sidebar)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants