Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support pwa in boilerplate template #262

Merged
merged 9 commits into from
Nov 4, 2024
Merged

Support pwa in boilerplate template #262

merged 9 commits into from
Nov 4, 2024

Conversation

0xaptosj
Copy link
Contributor

Tested on both iOS and Android

@0xaptosj 0xaptosj requested a review from 0xmaayan October 30, 2024 00:22
0xmaayan
0xmaayan reviewed Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@0xmaayan 0xmaayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good.

Why dont we add this as an option to the wizard? same as we do for Surf? We auto install bunch of things that are not needed for a non-PWA

@0xaptosj
Copy link
Contributor Author

overall looks good.

Why dont we add this as an option to the wizard? same as we do for Surf? We auto install bunch of things that are not needed for a non-PWA

@0xmaayan i think PWA is always good to have

@0xmaayan
Copy link
Collaborator

overall looks good.
Why dont we add this as an option to the wizard? same as we do for Surf? We auto install bunch of things that are not needed for a non-PWA

@0xmaayan i think PWA is always good to have

Ok, then lets add dev instructions to the README file and to the template page on Learn?

@0xaptosj
Copy link
Contributor Author

0xaptosj commented Oct 30, 2024 •
edited
Loading

overall looks good.
Why dont we add this as an option to the wizard? same as we do for Surf? We auto install bunch of things that are not needed for a non-PWA

@0xmaayan i think PWA is always good to have

Ok, then lets add dev instructions to the README file and to the template page on Learn?

@0xmaayan https://github.com/aptos-labs/aptos-learn/pull/443

0xmaayan
0xmaayan reviewed Oct 30, 2024
View reviewed changes
templates/boilerplate-template/README.md
@@ -22,6 +22,7 @@ To get started with the Boilerplate template and learn more about the template f
- Aptos TS SDK
- Aptos Wallet Adapter
- Node based Move commands
- [Vite-pwa](https://vite-pwa-org.netlify.app/)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we add a section explaining the end user

  1. what is PWA briefly
  2. once they have the boilerplate generated locally, what should they do?
  3. how to deploy it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated doc on learn

@0xaptosj 0xaptosj requested a review from 0xmaayan November 4, 2024 14:27
0xmaayan
0xmaayan approved these changes Nov 4, 2024
View reviewed changes
templates/nextjs-boilerplate-template/next.config.mjs
const nextConfig = {
import withPWAInit from "@ducanh2912/next-pwa";

const withPWA = withPWAInit({
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this being used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed, it's default to public anyway

@0xaptosj 0xaptosj merged commit c8b6c3b into main Nov 4, 2024
9 checks passed
@0xaptosj 0xaptosj deleted the j/support-pwa branch November 4, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xmaayan 0xmaayan 0xmaayan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xaptosj @0xmaayan