Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Namespaces aptos cli profile with the project name #122

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Namespaces aptos cli profile with the project name #122

merged 1 commit into from
Jun 24, 2024

Conversation

kaw2k
Copy link
Contributor

@kaw2k kaw2k commented Jun 24, 2024

use cli profile as - to not conflict with a possible global config file.

Tested with npm run move:init and npm run move:publish. Full flow worked.

@kaw2k kaw2k requested review from 0xmaayan and 0xaptosj June 24, 2024 19:34
@kaw2k kaw2k self-assigned this Jun 24, 2024
0xmaayan
0xmaayan approved these changes Jun 24, 2024
View reviewed changes
Copy link
Collaborator

@0xmaayan 0xmaayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@kaw2k kaw2k merged commit f2bc03e into main Jun 24, 2024
4 checks passed
@kaw2k kaw2k deleted the rasa/cli-profile-collision branch June 24, 2024 20:57
@0xmaayan 0xmaayan mentioned this pull request Jun 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xmaayan 0xmaayan 0xmaayan approved these changes

@0xaptosj 0xaptosj Awaiting requested review from 0xaptosj 0xaptosj is a code owner

Assignees

@kaw2k kaw2k

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaw2k @0xmaayan