Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up and refactor digital asset template #121

Merged
merged 2 commits into from
Jun 24, 2024
Merged

Clean up and refactor digital asset template #121

merged 2 commits into from
Jun 24, 2024

Conversation

0xmaayan
Copy link
Collaborator

Clean up and refactor digital asset code, folder structure, file names

@0xmaayan 0xmaayan requested review from kaw2k and 0xaptosj June 24, 2024 19:34
kaw2k
kaw2k reviewed Jun 24, 2024
View reviewed changes
Copy link
Contributor

@kaw2k kaw2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you run all this through npm run fmt? I feel like some of these lines are longer than 120.

@0xmaayan
Copy link
Collaborator Author

Did you run all this through npm run fmt? I feel like some of these lines are longer than 120.

yes, it passes. we also have a fmt check on CI

@0xmaayan 0xmaayan merged commit 1c9b96f into main Jun 24, 2024
4 checks passed
@0xmaayan 0xmaayan deleted the digital_asset_cleanup branch June 24, 2024 20:53
@0xmaayan 0xmaayan mentioned this pull request Jun 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaw2k kaw2k kaw2k approved these changes

@0xaptosj 0xaptosj Awaiting requested review from 0xaptosj 0xaptosj is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xmaayan @kaw2k