[abstraction] Add support for AccountAbstraction #622
+1,090
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GhostWalker562
force-pushed
the
account-abstraction-prod
branch
from
65d541a to
4a6ea55
Compare
lightmark
reviewed
Jan 30, 2025
| serializer.serializeStr(functionName); | ||
| serializer.serializeU32AsUleb128(AbstractionAuthDataVariant.V1); | ||
| serializer.serializeBytes(this.signingMessageDigest.toUint8Array()); | ||
| serializer.serializeFixedBytes(this.authenticator.toUint8Array()); |
There was a problem hiding this comment.
serializeBytes will add a length prefix to the start which may not be needed. Permission delegation also doesn't account for the length prefix.
By using serializeFixedBytes, the developer has 100% full control over the bytes for the authenticator.
kaw2k
reviewed
Jan 30, 2025
GhostWalker562
force-pushed
the
account-abstraction-prod
branch
3 times, most recently
from
f77d79e to
5645212
Compare
lightmark
reviewed
Jan 31, 2025
lightmark
approved these changes
Jan 31, 2025
kaw2k
reviewed
Jan 31, 2025
GhostWalker562
force-pushed
the
account-abstraction-prod
branch
from
5645212 to
99176a8
Compare
GhostWalker562
force-pushed
the
account-abstraction-prod
branch
from
99176a8 to
538bc15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces several new features and improvements related to account abstraction. The changes include adding new examples, new tests, and updating core account classes to support account abstraction.
AbstractedAccountwhich enables signing AA transactions using a custom signeraccount.abstractionnamespace which supports basic authentication function apis including adding functions, removing functions, and checking for whether functions exist.Test Plan
tests/e2e/abstraction.test.tsRelated Links
Checklist
pnpm fmt?CHANGELOG.md?