Add the `NoAccountAuthenticator` variant #467

junkil-park · 2024-07-16T18:55:30Z

Description

This PR updates the TypeScript SDK to support the simulation enhancement AIP: https://github.com/aptos-foundation/AIPs/blob/main/aips/aip-92.md.

Key Changes:

Simulation API Update: Allows users to simulate transactions without providing public keys by updating simulateTransaction to accept PublicKey | null instead of PublicKey. If null is provided, NoAccountAuthenticator is used as an authenticator. This new authenticator variant is supported by the Aptos VM as per this PR.

Multisig V2 Example Update: The multisig v2 example (multisig_v2.ts) is updated to reflect the change in the multisig transaction simulation behavior. To pre-check the multisig payload before creation, an entry function payload simulation with the multisig account as the sender and 0x0 as the fee payer is used.

Test Plan

This PR includes the following test scenarios:

Simulate a transaction without checking the authentication key when the public key is not provided (i.e., public key is null).
Simulate a fee payer transaction with fee payer as 0x0 and no public key of the fee payer provided.
Fail to execute a transaction when NoAccountAuthenticator is used.

Related Links

N.A.

0xmaayan

left initial comments. can we gat a PR description on what we are changing/adding here and why?

examples/typescript-esm/multisig_v2.ts

src/cli/localNode.ts

tests/e2e/transaction/transactionSubmission.test.ts

src/transactions/transactionBuilder/transactionBuilder.ts

junkil-park · 2024-07-18T16:28:56Z

left initial comments. can we gat a PR description on what we are changing/adding here and why?

Added!

0xmaayan

Did a first round

Please fix the linting errors - can run pnpm lint on the sdk root folder
When we have a property publicKey?:PublicKey it means the publicKey is of type PublicKey or undefined - please use this syntax
Please update CHANGELOG
Also, tests are failing

src/api/transactionSubmission/simulate.ts

tests/e2e/transaction/transactionSimulation.test.ts

0xmaayan

Let's address the PR comments, clean up the PR (lint and format errors) - then can do another final round

junkil-park · 2024-07-30T23:18:52Z

Did a first round

Please fix the linting errors - can run pnpm lint on the sdk root folder

Some are unavoidable, so I added eslint-disable-next-line for those cases.

When we have a property publicKey?:PublicKey it means the publicKey is of type PublicKey or undefined - please use this syntax

Done accordingly.

Please update CHANGELOG

Updated.

Also, tests are failing

They passed locally. It requires a custom localnet. Probably, this PR should wait until the aptos-core is ready for the new simulation enhancement feature?

0xmaayan

whats the migration process? looks like we first need to have the feature on mainnet? or are we good with only on devnet/testnet?
Can we make sure tests are passing with the localnet on main branch before merging it in?

examples/typescript/local_node.ts

src/api/transactionSubmission/simulate.ts

src/transactions/authenticator/account.ts

src/transactions/types.ts

tests/e2e/transaction/transactionSimulation.test.ts

tests/e2e/transaction/transactionSubmission.test.ts

examples/typescript-esm/multisig_v2.ts

src/transactions/transactionBuilder/transactionBuilder.ts

gregnazario · 2024-10-08T17:33:09Z

I rebased and fixed the conflicts.

junkil-park · 2024-10-10T00:48:13Z

I rebased and fixed the conflicts.

Thank you! We’re now waiting on the security review and the testnet/mainnet release before merging this PR.

examples/typescript-esm/multisig_v2.ts

src/transactions/transactionBuilder/transactionBuilder.ts

This PR adds the documentation for the change in aptos-labs/aptos-ts-sdk#467 (AIP-92: https://github.com/aptos-foundation/AIPs/blob/main/aips/aip-92.md).

Simulation API Update: Allows users to simulate transactions without providing public keys by updating simulateTransaction to accept PublicKey | null instead of PublicKey. If null is provided, NoAccountAuthenticator is used as an authenticator. Multisig V2 Example Update: The multisig v2 example (multisig_v2.ts) is updated to reflect the change in the multisig transaction simulation behavior. To pre-check the multisig payload before creation, an entry function payload simulation with the multisig account as the sender and 0x0 as the fee payer is used.

Includes the transaction simulation enhancement support: * https://github.com/aptos-foundation/AIPs/blob/main/aips/aip-92.md * #467

Includes the transaction simulation enhancement support: https://github.com/aptos-foundation/AIPs/blob/main/aips/aip-92.md Add the NoAccountAuthenticator variant #467

* Add the documentation for the transaction simulation enhancement This PR adds the documentation for the change in aptos-labs/aptos-ts-sdk#467 (AIP-92: https://github.com/aptos-foundation/AIPs/blob/main/aips/aip-92.md). * Update apps/nextra/pages/en/build/sdks/ts-sdk/building-transactions/multi-agent-transactions.mdx Co-authored-by: Greg Nazario <[email protected]> * Update apps/nextra/pages/en/build/sdks/ts-sdk/building-transactions/simulating-transactions.mdx Co-authored-by: Greg Nazario <[email protected]> * Update apps/nextra/pages/en/build/sdks/ts-sdk/building-transactions/simulating-transactions.mdx Co-authored-by: Greg Nazario <[email protected]> * Update apps/nextra/pages/en/build/sdks/ts-sdk/building-transactions/simulating-transactions.mdx Co-authored-by: Greg Nazario <[email protected]> * Update apps/nextra/pages/en/build/sdks/ts-sdk/building-transactions/simulating-transactions.mdx Co-authored-by: Greg Nazario <[email protected]> * Update apps/nextra/pages/en/build/sdks/ts-sdk/building-transactions/simulating-transactions.mdx Co-authored-by: Greg Nazario <[email protected]> * Update multi-agent-transactions.mdx --------- Co-authored-by: Greg Nazario <[email protected]>

0xmaayan reviewed Jul 16, 2024

View reviewed changes

junkil-park force-pushed the jpark/no-account-authenticator branch 2 times, most recently from b04e8e7 to 45d2d3d Compare July 18, 2024 16:50

junkil-park requested a review from 0xmaayan July 19, 2024 14:49

0xmaayan reviewed Jul 19, 2024

View reviewed changes

junkil-park force-pushed the jpark/no-account-authenticator branch from 45d2d3d to adf489b Compare July 22, 2024 15:53

0xmaayan reviewed Jul 22, 2024

View reviewed changes

junkil-park mentioned this pull request Jul 24, 2024

Enhance Transaction Simulation: Bypass Auth Key Check and Fee Payment, Improve Multisig Consistency aptos-labs/aptos-core#13714

Merged

15 tasks

junkil-park force-pushed the jpark/no-account-authenticator branch from adf489b to 6df62ec Compare July 30, 2024 22:31

junkil-park marked this pull request as ready for review July 30, 2024 22:31

junkil-park requested a review from a team as a code owner July 30, 2024 22:31

junkil-park force-pushed the jpark/no-account-authenticator branch from 6df62ec to c1778b9 Compare July 30, 2024 23:07

0xmaayan reviewed Aug 2, 2024

View reviewed changes

examples/typescript/local_node.ts Outdated Show resolved Hide resolved

src/api/transactionSubmission/simulate.ts Outdated Show resolved Hide resolved

src/transactions/authenticator/account.ts Show resolved Hide resolved

src/transactions/types.ts Show resolved Hide resolved

0xmaayan reviewed Aug 2, 2024

View reviewed changes

tests/e2e/transaction/transactionSimulation.test.ts Show resolved Hide resolved

0xmaayan reviewed Aug 2, 2024

View reviewed changes

tests/e2e/transaction/transactionSubmission.test.ts Outdated Show resolved Hide resolved

movekevin approved these changes Aug 2, 2024

View reviewed changes

junkil-park force-pushed the jpark/no-account-authenticator branch 2 times, most recently from 6381bf8 to e1f7ca3 Compare August 13, 2024 07:16

junkil-park requested a review from heliuchuan September 4, 2024 19:47

junkil-park force-pushed the jpark/no-account-authenticator branch 5 times, most recently from a404a42 to fcc63fe Compare September 14, 2024 01:02

junkil-park force-pushed the jpark/no-account-authenticator branch from fcc63fe to 05a3001 Compare September 17, 2024 22:23

junkil-park requested review from gregnazario and banool September 17, 2024 22:25

0xmaayan reviewed Sep 17, 2024

View reviewed changes

examples/typescript-esm/multisig_v2.ts Outdated Show resolved Hide resolved

src/transactions/transactionBuilder/transactionBuilder.ts Outdated Show resolved Hide resolved

src/transactions/transactionBuilder/transactionBuilder.ts Show resolved Hide resolved

0xmaayan mentioned this pull request Oct 2, 2024

Improve fee payer txn submission APIs #522

Merged

gregnazario force-pushed the jpark/no-account-authenticator branch from 05a3001 to 8b1d7bf Compare October 8, 2024 17:32

gregnazario force-pushed the jpark/no-account-authenticator branch from 73ad632 to 5fc34d5 Compare October 9, 2024 17:21

junkil-park force-pushed the jpark/no-account-authenticator branch 3 times, most recently from e495b5c to d645837 Compare November 8, 2024 06:00

0xmaayan reviewed Nov 8, 2024

View reviewed changes

examples/typescript-esm/multisig_v2.ts Outdated Show resolved Hide resolved

src/transactions/transactionBuilder/transactionBuilder.ts Outdated Show resolved Hide resolved

src/transactions/transactionBuilder/transactionBuilder.ts Outdated Show resolved Hide resolved

junkil-park force-pushed the jpark/no-account-authenticator branch 2 times, most recently from 07ca3c5 to a7807b2 Compare November 12, 2024 11:19

junkil-park mentioned this pull request Nov 12, 2024

Add the documentation for the transaction simulation enhancement aptos-labs/developer-docs#702

Merged

3 tasks

junkil-park force-pushed the jpark/no-account-authenticator branch from a7807b2 to 0b3205e Compare November 12, 2024 22:02

junkil-park requested a review from 0xmaayan November 12, 2024 22:04

junkil-park force-pushed the jpark/no-account-authenticator branch from b3d142c to 12e84d1 Compare November 12, 2024 23:13

junkil-park merged commit a013116 into main Nov 13, 2024
8 checks passed

junkil-park deleted the jpark/no-account-authenticator branch November 13, 2024 00:12

junkil-park mentioned this pull request Nov 13, 2024

Added the proposal to enable TRANSACTION_SIMULATION_ENHANCEMENT aptos-foundation/mainnet-proposals#121

Merged

junkil-park added a commit that referenced this pull request Nov 13, 2024

Bump to 1.32.2

58ea56a

Includes the transaction simulation enhancement support: * https://github.com/aptos-foundation/AIPs/blob/main/aips/aip-92.md * #467

junkil-park mentioned this pull request Nov 13, 2024

Bump to 1.33.0 #577

Merged

2 tasks

junkil-park added a commit that referenced this pull request Nov 13, 2024

Bump to 1.33.0

4ea7dbf

Includes the transaction simulation enhancement support: https://github.com/aptos-foundation/AIPs/blob/main/aips/aip-92.md Add the NoAccountAuthenticator variant #467

junkil-park added a commit that referenced this pull request Nov 13, 2024

Bump to 1.33.0 (#577)

0e487fd

Includes the transaction simulation enhancement support: https://github.com/aptos-foundation/AIPs/blob/main/aips/aip-92.md Add the NoAccountAuthenticator variant #467

junkil-park mentioned this pull request Nov 15, 2024

Update the correct script hash for transaction simulation enhancement aptos-foundation/mainnet-proposals#122

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add the `NoAccountAuthenticator` variant #467

Add the `NoAccountAuthenticator` variant #467

junkil-park commented Jul 16, 2024 •

edited

Loading

0xmaayan left a comment

junkil-park commented Jul 18, 2024

0xmaayan left a comment •

edited

Loading

0xmaayan left a comment

junkil-park commented Jul 30, 2024 •

edited

Loading

0xmaayan left a comment

gregnazario commented Oct 8, 2024

junkil-park commented Oct 10, 2024

Add the NoAccountAuthenticator variant #467

Add the NoAccountAuthenticator variant #467

Conversation

junkil-park commented Jul 16, 2024 • edited Loading

Description

Test Plan

Related Links

0xmaayan left a comment

Choose a reason for hiding this comment

junkil-park commented Jul 18, 2024

0xmaayan left a comment • edited Loading

Choose a reason for hiding this comment

0xmaayan left a comment

Choose a reason for hiding this comment

junkil-park commented Jul 30, 2024 • edited Loading

0xmaayan left a comment

Choose a reason for hiding this comment

gregnazario commented Oct 8, 2024

junkil-park commented Oct 10, 2024

Add the `NoAccountAuthenticator` variant #467

Add the `NoAccountAuthenticator` variant #467

junkil-park commented Jul 16, 2024 •

edited

Loading

0xmaayan left a comment •

edited

Loading

junkil-park commented Jul 30, 2024 •

edited

Loading