Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more meaningful API error messages #271

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Add more meaningful API error messages #271

merged 1 commit into from
Feb 1, 2024

Conversation

0xmaayan
Copy link
Collaborator

Description

When having API errors it is hard to understand what server errors out and most likely we get something like

AptosApiError: database query error

Screenshot 2024-01-31 at 4 18 56 PM

That is not really helpful in understanding WHAT service is down between the 3 - indexer, fullnode, faucet

Test Plan

Related Links

@0xmaayan 0xmaayan requested a review from a team as a code owner January 31, 2024 21:47
@0xmaayan 0xmaayan merged commit 44b6734 into main Feb 1, 2024
7 checks passed
@0xmaayan 0xmaayan deleted the meaningful_errors branch February 1, 2024 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants