[deps] Move event emitter to runtime dependency #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, it will fail to run with Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'eventemitter3' imported from /opt/git/aptos-playground/node_modules/.pnpm/@aptos-labs[email protected]/node_modules/@aptos-labs/ts-sdk/dist/esm/chunk-27YNIEGN.mjs
gregnazario
force-pushed
the
move-event-emitter-to-runtime
branch
from
a0898fc to
87e9761
Compare
0xmaayan
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, it will fail to run with
Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'eventemitter3' imported from /opt/git/aptos-playground/node_modules/.pnpm/@aptos-labs[email protected]/node_modules/@aptos-labs/ts-sdk/dist/esm/chunk-27YNIEGN.mjs
Description
Test Plan
Related Links