Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove request url forward slash append #264

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Conversation

0xmaayan
Copy link
Collaborator

Description

For custom URLs, users might define a url with a forward slash (/). The SDK appends a forward slash be default and it can lead to errors.

https://www.domain.com/v1/ -> SDK will change it to https://www.domain.com/v1//

This PR remove the default forward slash append so URLs stay the same

Test Plan

Related Links

@0xmaayan 0xmaayan requested a review from a team January 24, 2024 17:35
@0xmaayan 0xmaayan merged commit 95a54f4 into main Jan 24, 2024
7 checks passed
@0xmaayan 0xmaayan deleted the remove_forward_slash_append branch January 24, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants