Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[faucet] Remove waitForIndexer for faucet fundAccount #262

Closed
wants to merge 1 commit into from

Conversation

hariria
Copy link
Contributor

@hariria hariria commented Jan 24, 2024

Description

Unneeded waitForIndexer call for faucet.

Test Plan

pnpm lint && pnpm unit-test
Got the same number of errors locally (before and after any changes) running pnpm api-test 🤷

@hariria hariria requested review from 0xmaayan and 0xmigo January 24, 2024 16:45
@0xmaayan
Copy link
Collaborator

pnpm test includes both pnpm unit-test and pnpm api-test, tho for this change pnpm api-test is enough as this piece of code is only tested in api-tests.

Local tests should not fail locally. If it does it might be because localnet (probably a indexer processor) breaks and need to restart it.

I am not fully convinced waitForIndexer is not needed. If indexer doesnt catch up it might be something wrong with indexer. Also, you should be able to disable this default behavior with options: { waitForIndexer: false }

@hariria
Copy link
Contributor Author

hariria commented Jan 24, 2024

Ok fair. ill close

@hariria hariria closed this Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants