Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit build | simulate | submit from aptos namespace #249

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

0xmaayan
Copy link
Collaborator

@0xmaayan 0xmaayan commented Jan 4, 2024

Description

Fix #243

build | simulate | submit properties are available on aptos namespace but they are not functional - that causes confusion for devs that could see those properties on autocomplete under the aptos namespace but then their program breaks. Those properties should only be visible under the aptos.transaction namespace

Test Plan

pnpm test

and

const aptos = new Aptos();
aptos. // autocomplete should not show build | simulate | submit
aptos.transaction // autocomplete should show build | simulate | submit

Related Links

@0xmaayan 0xmaayan requested review from gregnazario, 0xmigo, heliuchuan and a team as code owners January 4, 2024 21:24
@0xmaayan 0xmaayan enabled auto-merge (squash) January 4, 2024 21:27
@0xmaayan 0xmaayan merged commit 93fceec into main Jan 4, 2024
10 checks passed
@0xmaayan 0xmaayan deleted the omit_props_aptos_namespace branch January 4, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Some properties not exist in Aptos client but could pass type check
4 participants