Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release] Release stable version 1.0.0 #223

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Conversation

0xmaayan
Copy link
Collaborator

@0xmaayan 0xmaayan commented Dec 4, 2023

Description

  • Bump version on package.json and version.ts
  • Generate docs
  • Update readme.md

Test Plan

Related Links

Copy link
Collaborator

@gregnazario gregnazario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's rename the commit message to :

[release] Release stable version 1.0.0

This will make it easier to look through the commit log later.

@@ -6,4 +6,4 @@
*
* hardcoded for now, we would want to have it injected dynamically
*/
export const VERSION = "0.0.8";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may be confusing with the other docs, were we going to go forward with 2.0.0, or we need to change the docs instead of saying go to 2.0.0, instead go to the new repository.

Copy link
Collaborator

@gregnazario gregnazario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There may be a page you have to update at docs/index.md as well

@0xmaayan 0xmaayan force-pushed the first_stable_version branch from 242b678 to 1d9bedd Compare December 4, 2023 20:39
@0xmaayan 0xmaayan changed the title First stable version [release] Release stable version 1.0.0 Dec 4, 2023
@0xmaayan 0xmaayan force-pushed the first_stable_version branch from 1d9bedd to 21a4aaf Compare December 4, 2023 21:09
@0xmaayan
Copy link
Collaborator Author

0xmaayan commented Dec 4, 2023

There may be a page you have to update at docs/index.md as well

done https://github.com/aptos-labs/aptos-ts-sdk/pull/223/files#diff-b4d68dc855d0f9476d3f2ee343853bd21bf82ea9960d0cf06661baa244439dd6

@0xmaayan 0xmaayan merged commit 9db6bd3 into main Dec 4, 2023
5 checks passed
@0xmaayan 0xmaayan deleted the first_stable_version branch December 4, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants